Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kola: add test that checks that falco module can be built and loaded #339

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

jepio
Copy link
Member

@jepio jepio commented Jun 15, 2022

add falco module test

This tests uses the master ref of falcosecurity/falco-driver-loader, but can soon be moved to 0.33.0 once that is released. Selinux needs to be disabled because it blocks insmod from within the container.

How to use

[ describe what reviewers need to do in order to validate this PR ]

Testing done

Test succeeded: http://jenkins.infra.kinvolk.io:8080/job/os/job/kola/job/qemu/553/

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)

@jepio jepio requested a review from a team June 15, 2022 15:07
Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this test and for the great work around this topic ! 🥳

kola/tests/misc/falco.go Show resolved Hide resolved
kola/tests/misc/falco.go Show resolved Hide resolved
kola/tests/misc/falco.go Show resolved Hide resolved
Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's monitor if we hit the docker pull rate limit but it should be OK. One last thing before merging: could you add a changelog entry ?

@jepio
Copy link
Member Author

jepio commented Jun 22, 2022

Done

@jepio jepio merged commit bf17b68 into flatcar-master Jun 22, 2022
@jepio jepio deleted the jepio/falco-test branch June 22, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants