Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcp image features (UEFI/GVNIC) #322

Merged
merged 5 commits into from
Apr 20, 2022
Merged

Conversation

jepio
Copy link
Member

@jepio jepio commented Apr 13, 2022

gcp image features

This PR marks published GCP images as supporting UEFI and GVNIC.

Marking the images as UEFI automatically makes instances boot with UEFI and have access to a VTPM.

Marking the image as support GVNIC does not automatically make it active but allows users to choose GVNIC. Therefore I intend to backport flatcar-archive/coreos-overlay#1802 to all releases. For kola testing a new flat is added that enables GVNIC on tested instances.

How to use

[ describe what reviewers need to do in order to validate this PR ]

Testing done

Tested here: http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/5373/cldsv/, fetch the latest os/kola/gce console logs and look for gve/gvnic/EFI.

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)

@jepio jepio requested a review from a team April 13, 2022 08:08
@jepio jepio changed the base branch from flatcar-master to tormath1/bump-go April 13, 2022 08:09
@jepio
Copy link
Member Author

jepio commented Apr 13, 2022

Base is chosen intentionally - when tormath1/bump-go is merged this PR will be re-targeted at flatcar-master.

@jepio jepio force-pushed the jepio/gcp-image-features branch from a32561d to a33872b Compare April 13, 2022 08:10
Base automatically changed from tormath1/bump-go to flatcar-master April 13, 2022 08:50
@jepio jepio force-pushed the jepio/gcp-image-features branch from a33872b to fe343af Compare April 13, 2022 09:53
Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! This is cool. If I understand correctly, we would also need to update GCP testing script to supply --gce-gvnic for supported versions ?

@jepio
Copy link
Member Author

jepio commented Apr 13, 2022

Yes, we'll probably add a 'cl.internet' test with this option to the GCP testing.

jepio added 5 commits April 13, 2022 15:37
This is a result of doing:

  go get -u google.golang.org/api
  go mod tidy
  go mod vendor

The updated APIs are needed to be able to enable GVNIC.
Published images now automatically run with UEFI boot mode and have opt-in
support for GVNIC.
@jepio jepio force-pushed the jepio/gcp-image-features branch from fe343af to daf34b7 Compare April 13, 2022 13:38
@jepio
Copy link
Member Author

jepio commented Apr 20, 2022

Will merge this after the GCP vnic support is cherry-picked everywhere.

@jepio
Copy link
Member Author

jepio commented Apr 20, 2022

The coreos-overlay PR has been cherry-picked to everything back to 3033, so it is now safe to merge this.

@jepio jepio merged commit 8c5cc91 into flatcar-master Apr 20, 2022
@jepio jepio deleted the jepio/gcp-image-features branch April 20, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants