-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcp image features (UEFI/GVNIC) #322
Conversation
Base is chosen intentionally - when tormath1/bump-go is merged this PR will be re-targeted at flatcar-master. |
a32561d
to
a33872b
Compare
a33872b
to
fe343af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! This is cool. If I understand correctly, we would also need to update GCP testing script to supply --gce-gvnic
for supported versions ?
Yes, we'll probably add a 'cl.internet' test with this option to the GCP testing. |
This is a result of doing: go get -u google.golang.org/api go mod tidy go mod vendor The updated APIs are needed to be able to enable GVNIC.
Published images now automatically run with UEFI boot mode and have opt-in support for GVNIC.
fe343af
to
daf34b7
Compare
Will merge this after the GCP vnic support is cherry-picked everywhere. |
The coreos-overlay PR has been cherry-picked to everything back to 3033, so it is now safe to merge this. |
gcp image features
This PR marks published GCP images as supporting UEFI and GVNIC.
Marking the images as UEFI automatically makes instances boot with UEFI and have access to a VTPM.
Marking the image as support GVNIC does not automatically make it active but allows users to choose GVNIC. Therefore I intend to backport flatcar-archive/coreos-overlay#1802 to all releases. For kola testing a new flat is added that enables GVNIC on tested instances.
How to use
[ describe what reviewers need to do in order to validate this PR ]
Testing done
Tested here: http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/5373/cldsv/, fetch the latest os/kola/gce console logs and look for gve/gvnic/EFI.
changelog/
directory (user-facing change, bug fix, security fix, update)