plume: Use the public bucket proxy for anonymous access #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
force-pushed
the
kai/plume-anonymous
branch
from
e234bb2 to
e4eb4a6
Compare
pothos
changed the title
pothos
force-pushed
the
kai/plume-anonymous
branch
from
e4eb4a6 to
7a3756f
Compare
|
LGTM, we can maybe add a changelog entry since it brings a high level update ? |
pothos
force-pushed
the
kai/plume-anonymous
branch
from
7a3756f to
d68c7c3
Compare
|
Thanks, done |
tormath1
reviewed
Nov 22, 2021
tormath1
approved these changes
Nov 22, 2021
The image download from the bucket is not possible anymore directly but needs to be done through the HTTP proxy. Create a limited bucket object for anonymous access, which can only download particular files and has no listing or upload ability. Calling code needs to make sure it only tries uploads or directory listings when the bucket object is using a proper gs:// URL and that it configured credentials before trying to upload.
pothos
force-pushed
the
kai/plume-anonymous
branch
from
674eb61 to
ebd3a85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image download from the bucket is not possible anymore directly but
needs to be done through the HTTP proxy.
Create a limited bucket object for anonymous access, which can only
download particular files and has no listing or upload ability.
Calling code needs to make sure it only tries uploads or directory
listings when the bucket object is using a proper gs:// URL and that
it configured credentials before trying to upload.
How to use
Testing done