Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kola: remove legacy kubernetes test #250

Merged
merged 3 commits into from
Nov 12, 2021

Conversation

tormath1
Copy link
Contributor

These tests are now deprecated due to the stabilization of Docker >= 20.10.

@tormath1 tormath1 self-assigned this Nov 10, 2021
this one are deprecated since we run docker >= 20.10

Signed-off-by: Mathieu Tortuyaux <[email protected]>
Signed-off-by: Mathieu Tortuyaux <[email protected]>
@tormath1 tormath1 force-pushed the tormath1/remove-legacy-docker-test branch from ed05578 to edcd39b Compare November 10, 2021 16:11
@tormath1 tormath1 marked this pull request as ready for review November 10, 2021 16:21
@tormath1 tormath1 requested a review from a team November 10, 2021 16:21
@krnowak
Copy link
Member

krnowak commented Nov 10, 2021

Is there a way to make those tests compatible with docker 20.10? Or is this pointless?

@tormath1
Copy link
Contributor Author

Is there a way to make those tests compatible with docker 20.10? Or is this pointless?

@krnowak that's indeed a good question - kubernetes tests are now superseded by kubeadm one, which rely directly on docker container runtime and test more up-to-date Kubernetes maintained versions (1.21, 1.22 and soon 1.23)

@krnowak
Copy link
Member

krnowak commented Nov 10, 2021

So these kubernetes tests were testing more-or-less the same thing as the new kubeadm tests? So bumping the kubernetes versions to actively supported ones in kubernetes test would result in a some kind of duplication? If that would be so, then I think it's fine to drop the tests.

@tormath1
Copy link
Contributor Author

tormath1 commented Nov 10, 2021

@krnowak that's right.

Currently with kubernetes tests, we are testing the following versions:
https://github.com/flatcar-linux/mantle/blob/6336d5f143909cc080b95c4c4826b383ff3ac0c0/kola/tests/kubernetes/basic.go#L31-L36

While with kubeadm we are testing1:

  • v1.22.0
  • v1.21.0

On top of different tested versions, we can also mention that:

  • we test calico, flannel and cilium CNIs with kubeadm
  • as mentioned in the name kubeadm tests deploy Kubernetes using kubeadm

Footnotes

  1. https://github.com/flatcar-linux/mantle/blob/flatcar-master/kola/tests/kubeadm/kubeadm.go#L46-L69

@krnowak
Copy link
Member

krnowak commented Nov 10, 2021

Alright, let's drop the tests.

Also, I had a look at https://endoflife.date/kubernetes and I was wondering if kubeadm tests should also test version 1.20. But probably no point in it, as its active support expires in one month, and maintenance in 3. Also, different PR for it anyway.

@tormath1 tormath1 merged commit ce713f3 into flatcar-master Nov 12, 2021
@tormath1 tormath1 deleted the tormath1/remove-legacy-docker-test branch November 12, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants