kola/test/oem: add ignition OEM test #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krnowak
reviewed
Sep 21, 2021
kola/tests/ignition/oem.go
Outdated
|
|
||
| // reusePartition asserts that even if the config uses a different fs format, we keep using `btrfs`. | ||
| func reusePartition(c cluster.TestCluster) { | ||
| out := c.MustSSH(c.Machines()[0], `lsblk --output FSTYPE,LABEL,MOUNTPOINT -J | jq -r '.blockdevices | .[] | select(.label=="OEM") | .fstype'`) |
There was a problem hiding this comment.
I usually prefer to use long options in scripts and code, leaving short flags for daily use in the terminal. I think it improves readability.
Suggested change
| out := c.MustSSH(c.Machines()[0], `lsblk --output FSTYPE,LABEL,MOUNTPOINT -J | jq -r '.blockdevices | .[] | select(.label=="OEM") | .fstype'`) | |
| out := c.MustSSH(c.Machines()[0], `lsblk --output FSTYPE,LABEL,MOUNTPOINT --json | jq -r '.blockdevices | .[] | select(.label=="OEM") | .fstype'`) |
kola/tests/ignition/oem.go
Outdated
|
|
||
| // wipeOEM asserts that if the config uses a different fs format with a wipe of the fs we effectively wipe the fs. | ||
| func wipeOEM(c cluster.TestCluster) { | ||
| out := c.MustSSH(c.Machines()[0], `lsblk --output FSTYPE,LABEL,MOUNTPOINT -J | jq -r '.blockdevices | .[] | select(.label=="OEM") | .fstype'`) |
There was a problem hiding this comment.
Same here.
Suggested change
| out := c.MustSSH(c.Machines()[0], `lsblk --output FSTYPE,LABEL,MOUNTPOINT -J | jq -r '.blockdevices | .[] | select(.label=="OEM") | .fstype'`) | |
| out := c.MustSSH(c.Machines()[0], `lsblk --output FSTYPE,LABEL,MOUNTPOINT --json | jq -r '.blockdevices | .[] | select(.label=="OEM") | .fstype'`) |
pothos
reviewed
Sep 21, 2021
| Run: reusePartition, | ||
| ClusterSize: 1, | ||
| Distros: []string{"cl"}, | ||
| UserData: conf.ContainerLinuxConfig(`storage: |
There was a problem hiding this comment.
I think this needs to be gated behind a minimal release version 2983.0.0
krnowak
approved these changes
Sep 21, 2021
pothos
approved these changes
Sep 21, 2021
Signed-off-by: Mathieu Tortuyaux <[email protected]>
Signed-off-by: Mathieu Tortuyaux <[email protected]>
tormath1
force-pushed
the
tormath1/add-oem-test
branch
from
2ddaec8 to
1a7dcc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mathieu Tortuyaux [email protected]
In this PR, we try to test the usage of OEM - which is too required to run tests for the "new" ignition(v2/v3)
Closes: flatcar/Flatcar#486
Three tests:
btrfsformatext4formatwipeFilesystemHow to use
Testing done
Only on
qemu.