Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Fix top_k_top_p_sampling_from_logits param typo #875

Merged
merged 1 commit into from
Feb 18, 2025
Merged

[API] Fix top_k_top_p_sampling_from_logits param typo #875

merged 1 commit into from
Feb 18, 2025

Conversation

kasohrab
Copy link
Contributor

Resolves #873

yzh119
yzh119 approved these changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@yzh119 yzh119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@yzh119 yzh119 merged commit 68a0378 into flashinfer-ai:main Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzh119 yzh119 yzh119 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API] Typo in parameter list for fused sampling kernel (top_k_top_p_sampling_from_logits)
2 participants
@kasohrab @yzh119