bugfix: Ensure Loop Termination by Enforcing IEEE-754 Compliance in Sampling Kernels #774
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #769.
As discussed in this comment, the use of the approximate division instruction
div.approx.ftz.f32
can break the loop invariant, preventing the loop from terminating. To resolve this, this PR changes the data types oflow
,high
, andmid
todouble
, ensuring that the compiler maintains IEEE-754 compliance and preserves numerical stability.