pinterest-source-32

[JessicaKMarkiewicz]

Please provide your name and company
Jessica Markiewicz

Link the issue/feature request which this PR is meant to address

Issue #32

Detail what changes this PR introduces and how this addresses the issue/feature request linked above.

• Updated the is_most_recent_record window function in the following models to exclude the source_relation field from the partition statement when pinterest_ads_union_schemas or pinterest_ads_union_databases variables are empty. Also, modified it to skip the window function if the upstream table is empty, using the new window_function_if_table_exists() and is_table_empty() macros. This change addresses Redshift's issue with partitioning by constant expressions.
  • stg_pinterest_ads__ad_group_history
  • stg_pinterest_ads__advertiser_history
  • stg_pinterest_ads__campaign_history
  • stg_pinterest_ads__keyword_history
  • stg_pinterest_ads__pin_promotion_history

How did you validate the changes introduced within this PR?

• Confirmed based off LinkedIn draft PR

Which warehouse did you use to develop these changes?

• Did not run, just made code changes.

Did you update the CHANGELOG?

• Yes

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

• Yes

Typically there are additional maintenance changes required before this will be ready for an upcoming release. Are you comfortable with the Fivetran team making a few commits directly to your branch?

• Yes
• No

If you had to summarize this PR in an emoji, which would it be?

😸

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

PR Template

• Community Pull Request Template (default)

• Maintainer Pull Request Template (to be used by maintainers)

[fivetran-joemarkiewicz]

@JessicaKMarkiewicz thanks so much for contributing this PR! 🎉

This PR looks great and should do the trick to address the original issue. There are a few final changes necessary before this will be good to merge into main and we also need to ensure it passes our integration tests. Therefore, I'll plan to merge this into a release branch to make those final changes and tests.

I imagine you should see this integrated into the main Pinterest Source release by the end of the week.