Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native module doesn't compile against Node.js v10.2.0 #50

Closed
tvdstaaij opened this issue May 24, 2018 · 3 comments
Closed

Native module doesn't compile against Node.js v10.2.0 #50

tvdstaaij opened this issue May 24, 2018 · 3 comments

Comments

@tvdstaaij
Copy link

v10.1 works fine but both my build server and local machine can't install i2c-bus with v10.2. Log:

$ node --version
v10.2.0
$ npm --version
5.6.0
$ npm install

> [email protected] install /home/user/git/node-i2c-adt7420/node_modules/i2c-bus
> node-gyp rebuild

make: Entering directory '/home/user/git/node-i2c-adt7420/node_modules/i2c-bus/build'
  CXX(target) Release/obj.target/i2c/src/i2c.o
In file included from ../src/i2c.cc:1:0:
/home/user/.node-gyp/10.2.0/include/node/node.h:53:10: fatal error: core.h: No such file or directory
 #include "core.h"  // NOLINT(build/include_order)
          ^~~~~~~~
compilation terminated.
make: *** [i2c.target.mk:97: Release/obj.target/i2c/src/i2c.o] Error 1
make: Leaving directory '/home/user/git/node-i2c-adt7420/node_modules/i2c-bus/build'
@tvdstaaij
Copy link
Author

Looks like this is a nodejs / node-gyp bug: nodejs/node#20921

@fivdi
Copy link
Owner

fivdi commented May 24, 2018

@tvdstaaij Thanks for the report.

Lets leave this issue open until Node.js v10.2.1 is released with a fix.

@fivdi
Copy link
Owner

fivdi commented May 25, 2018

Node.js v10.2.1 has been release and is available for download at https://nodejs.org/dist/v10.2.1/.
It should be possible to install i2c-bus with this release without errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants