Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix store_failures modifier for unique, not_null #3577

Merged
merged 3 commits into from
Jul 16, 2021
Merged

Fix store_failures modifier for unique, not_null #3577

merged 3 commits into from
Jul 16, 2021

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented Jul 15, 2021 •
edited
Loading

resolves #3575

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Jul 15, 2021
@jtcohen6 jtcohen6 temporarily deployed to Snowflake July 15, 2021 00:18 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Snowflake July 15, 2021 00:18 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Redshift July 15, 2021 00:18 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Redshift July 15, 2021 00:18 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Bigquery July 15, 2021 00:18 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Bigquery July 15, 2021 00:18 Inactive
@jtcohen6 jtcohen6 marked this pull request as ready for review July 15, 2021 22:30
@jtcohen6 jtcohen6 requested review from a team, leahwicz and iknox-fa and removed request for a team July 15, 2021 22:30
@jtcohen6 jtcohen6 merged commit 0ae93c7 into develop Jul 16, 2021
@jtcohen6 jtcohen6 deleted the fix/store-failures-modifier branch July 16, 2021 18:50
jtcohen6 added a commit that referenced this pull request Jul 16, 2021
@jtcohen6
Fix store_failures modifier for unique, not_null (#3577)
7d69adb 
* Fix store_failures modifier for unique, not_null

* Add test, changelog
@jtcohen6 jtcohen6 temporarily deployed to Snowflake July 16, 2021 18:55 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Snowflake July 16, 2021 18:55 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Bigquery July 16, 2021 18:55 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Bigquery July 16, 2021 18:55 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Redshift July 16, 2021 18:55 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Redshift July 16, 2021 18:55 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahwicz leahwicz leahwicz approved these changes

@iknox-fa iknox-fa Awaiting requested review from iknox-fa

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot set store_failures as test modifier for unique, not_null
2 participants
@jtcohen6 @leahwicz