Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google cloud dependencies #3156

Merged
merged 5 commits into from
Apr 2, 2021
Merged

Update google cloud dependencies #3156

merged 5 commits into from
Apr 2, 2021

Conversation

max-sixty
Copy link
Contributor

@max-sixty max-sixty commented Mar 11, 2021

resolves #3155

Description

As per the last one of these, another bump to latest.

These are now more stable, so you may want to only pin the major version — let me know if you'd like me to make that change.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Mar 11, 2021
@jtcohen6
Copy link
Contributor

Thanks @max-sixty!

These are now more stable, so you may want to only pin the major version — let me know if you'd like me to make that change.

I'd love to be in a place of having major-version boundaries for these. It's not such a chore to upgrade them every minor release, but tighter pins result in inevitable delays. Could you say a bit more about the improved stability, based on what you've observed / read / heard?

@max-sixty
Copy link
Contributor Author

I'd love to be in a place of having major-version boundaries for these. It's not such a chore to upgrade them every minor release, but tighter pins result in inevitable delays. Could you say a bit more about the improved stability, based on what you've observed / read / heard?

I don't have a more reliable signal than my own experience, unfortunately. I'm trying to think of a good one — maybe whether dbt has had to make any changes to its library when upgrading — do you know whether it has?

In my experience — this used to be a big problem and I used to complain about it — and in the last year at least, I haven't found it a problem at all.

@max-sixty
Copy link
Contributor Author

Any thoughts on merging? I see 0.19.1 came out today.

@jtcohen6
Copy link
Contributor

jtcohen6 commented Apr 1, 2021

maybe whether dbt has had to make any changes to its library when upgrading — do you know whether it has?

I don't believe we've had to do this for some time. At the same time, I know we see some deprecation warnings from the BigQuery python client, e.g.

Client.dataset is deprecated and will be removed in a future version. Use a string like 'my_project.my_dataset' or a cloud.google.bigquery.DatasetReference object, instead.

In any case, I think I'd be open to trying to relax the pins (major-version upper bounds instead of minor ones) in v0.20. We could merge that change now, and see if we run into any trouble between now and the final v0.20.0 release.

@max-sixty
Copy link
Contributor Author

Great! Done!

@jtcohen6
Copy link
Contributor

jtcohen6 commented Apr 2, 2021

Nice, thank you! Could you also remove the associated comment ("these are more tightly pinned"), and add a changelog entry?

@max-sixty
Copy link
Contributor Author

Nice, thank you! Could you also remove the associated comment ("these are more tightly pinned"), and add a changelog entry?

Good spot, both done

Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @max-sixty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update google cloud dependencies
2 participants