-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update google cloud dependencies #3156
Conversation
Thanks @max-sixty!
I'd love to be in a place of having major-version boundaries for these. It's not such a chore to upgrade them every minor release, but tighter pins result in inevitable delays. Could you say a bit more about the improved stability, based on what you've observed / read / heard? |
I don't have a more reliable signal than my own experience, unfortunately. I'm trying to think of a good one — maybe whether dbt has had to make any changes to its library when upgrading — do you know whether it has? In my experience — this used to be a big problem and I used to complain about it — and in the last year at least, I haven't found it a problem at all. |
Any thoughts on merging? I see 0.19.1 came out today. |
I don't believe we've had to do this for some time. At the same time, I know we see some deprecation warnings from the BigQuery python client, e.g.
In any case, I think I'd be open to trying to relax the pins (major-version upper bounds instead of minor ones) in v0.20. We could merge that change now, and see if we run into any trouble between now and the final v0.20.0 release. |
Great! Done! |
Nice, thank you! Could you also remove the associated comment ("these are more tightly pinned"), and add a changelog entry? |
Good spot, both done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @max-sixty!
resolves #3155
Description
As per the last one of these, another bump to latest.
These are now more stable, so you may want to only pin the major version — let me know if you'd like me to make that change.
Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.