Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unixodbc-dev to testing docker image #2859

Merged
merged 2 commits into from
Oct 30, 2020
Merged

add unixodbc-dev to testing docker image #2859

merged 2 commits into from
Oct 30, 2020

Conversation

kwigley
Copy link
Contributor

@kwigley kwigley commented Oct 29, 2020 •
edited
Loading

Description

Updates Dockerfile for fishtownanalytics/test-container image. Adds unixodbc-dev packages required for installing pyodbc (docs).

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@kwigley kwigley requested review from gshank and drewbanin October 29, 2020 20:24
@cla-bot cla-bot bot added the cla:yes label Oct 29, 2020
@kwigley
Copy link
Contributor Author

kwigley commented Oct 29, 2020

Once approved, I'll build and push an image with tag fishtownanalytics/test-container:10 to use in dbt-spark

kwigley
kwigley commented Oct 29, 2020
View reviewed changes
Dockerfile
libsasl2-2 \
libsasl2-modules-gssapi-mit \
libyaml-dev \
unixodbc-dev \
Copy link
Contributor Author

@kwigley kwigley Oct 29, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for formatting! unixodbc-dev is the only new package here

drewbanin
drewbanin approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Were you able to test this locally?

@kwigley
Copy link
Contributor Author

kwigley commented Oct 29, 2020 •
edited
Loading

LGTM! Were you able to test this locally?

@drewbanin Yep 👍

@kwigley kwigley merged commit 4e19e87 into dev/kiyoshi-kuromiya Oct 30, 2020
@kwigley kwigley deleted the fix/update-test-container branch October 30, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshank gshank gshank approved these changes

@drewbanin drewbanin drewbanin approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kwigley @gshank @drewbanin