Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set store_failures as test modifier for unique, not_null #3575

Closed
jtcohen6 opened this issue Jul 14, 2021 · 0 comments · Fixed by #3577
Closed

Cannot set store_failures as test modifier for unique, not_null #3575

jtcohen6 opened this issue Jul 14, 2021 · 0 comments · Fixed by #3577
Labels
bug Something isn't working dbt tests Issues related to built-in dbt testing functionality
Milestone

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Jul 14, 2021

Describe the bug

Cannot set store_failures config on unique and not_null tests:

  - name: my_model
    columns: 
      - name: id
        tests:
          - not_null:
              store_failures: true # does not take effect

These built-in tests use an optimized codepath for test construction at parse time.

We either missed this in the original PR, or it got lost in the git merge/rebases. It's a super simple fix.

While here, I realized that I think we're not doing unrendered_config quite right. That's a separate issue to look into. (edit: opened #3576)

@jtcohen6 jtcohen6 added the bug Something isn't working label Jul 14, 2021
@jtcohen6 jtcohen6 added this to the 0.20.1 milestone Jul 14, 2021
@jtcohen6 jtcohen6 added the dbt tests Issues related to built-in dbt testing functionality label Jul 15, 2021
@jtcohen6 jtcohen6 self-assigned this Jul 15, 2021
@jtcohen6 jtcohen6 removed their assignment Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dbt tests Issues related to built-in dbt testing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant