Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add column-level quoting for tests (#2047) #2106

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Feb 7, 2020

Fixes #2047

add support in columns for a quote field
add support in source quoting for a column field
add support in models for a quote_columns field
add tests

add support in columns for a quote field
add support in source quoting for a column field
add support in models for a quote_columns field
add tests
@cla-bot cla-bot bot added the cla:yes label Feb 7, 2020
@beckjake beckjake requested a review from drewbanin February 7, 2020 21:25
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this all looks right in the docs site:

Screen Shot 2020-02-10 at 3 55 06 PM

These tests are great. Ship it!

@beckjake beckjake merged commit 5e3eba6 into dev/barbara-gittings Feb 10, 2020
@beckjake beckjake deleted the feature/column-quoting branch February 10, 2020 20:58
@bcg0006
Copy link

bcg0006 commented Mar 11, 2020

@drewbanin when do you expect that this fix will be released? Thanks.

@drewbanin
Copy link
Contributor

@bcg0006 https://discourse.getdbt.com/t/pre-release-v0-16-0-barbara-gittings/922/13

Should be end of this week or early next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug for web generated documentation
3 participants