Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove display of tax details on grouped products #150

Closed
grossmann opened this issue Jan 15, 2020 · 3 comments
Closed

Remove display of tax details on grouped products #150

grossmann opened this issue Jan 15, 2020 · 3 comments

Comments

@grossmann
Copy link

Related issue: #56

General

  • Module version: 1.2.1
  • Magento version: 2.3.3
  • PHP version: 7.2.x

Issue description

Magento 2.3.3 doesn't show a price on grouped products (only in the list for each of the associated simple products).
Therefore the tax and shipping cost details shouldn't be shown there as well, but they are.

Steps to reproduce

  1. Create a grouped product with at least one simple product associated
  2. See the tax and shipping info right below the delivery time info as no price is shown.
@sprankhub
Copy link
Member

If prices are still shown (no matter where), doesn't it then still make sense to have a tax hint? Maybe it is just at a weird place for grouped products?

@grossmann
Copy link
Author

The tax hint is (sensfull) shown on the single items but also on the grouped product which has no price by itself. See the image for better understanding.
grafik

@sprankhub
Copy link
Member

Fixed in #155.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants