Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[📚] pub.dev claims Windows support #11733

Closed
adil192 opened this issue Oct 18, 2023 · 3 comments
Closed

[📚] pub.dev claims Windows support #11733

adil192 opened this issue Oct 18, 2023 · 3 comments
Labels
good first issue Good for newcomers resolution: solution-provided A solution has been provided in the issue. type: documentation Improvements or additions to documentation

Comments

@adil192
Copy link

adil192 commented Oct 18, 2023

The pub.dev page says that the package supports Windows.
pub.dev screenshot

However, running flutterfire configure generates this code:

class DefaultFirebaseOptions {
  static FirebaseOptions get currentPlatform {
    // ...
      case TargetPlatform.windows:
        throw UnsupportedError(
          'DefaultFirebaseOptions have not been configured for windows - '
          'you can reconfigure this by running the FlutterFire CLI again.',
        );
      case TargetPlatform.linux:
        throw UnsupportedError(
          'DefaultFirebaseOptions have not been configured for linux - '
          'you can reconfigure this by running the FlutterFire CLI again.',
        );

https://firebase.google.com/docs/flutter/setup doesn't contain any instructions to configure firebase for Windows.

If the package doesn't support Windows, then the pub.dev page should be updated.
Otherwise, it would be helpful if the documentation was updated to explain how to setup Windows support.

@adil192 adil192 added good first issue Good for newcomers type: documentation Improvements or additions to documentation labels Oct 18, 2023
@darshankawar darshankawar added the triage Issue is currently being triaged. label Oct 19, 2023
@darshankawar
Copy link

darshankawar commented Oct 19, 2023

The pub.dev page says that the package supports Windows.

The package does now support Windows, as part of this PR

However, running flutterfire configure generates this code:

You might need to raise this in dedicated repo to get the tool update the windows specific implementation.

https://firebase.google.com/docs/flutter/setup doesn't contain any instructions to configure firebase for Windows.

The Windows support has been added just a week ago, so the instructions should get updated soon.

If the package doesn't support Windows, then the pub.dev page should be updated.

It does support now per the fixed PR.

I'll close this for now, as flutterfire configure related issue should be addressed in other repo. If the documentation is not yet updated soon, will reopen it. If you disagree, write in comments and I'll reopen anyway.

Also, check this issue for reference.

@darshankawar darshankawar added resolution: solution-provided A solution has been provided in the issue. and removed triage Issue is currently being triaged. labels Oct 19, 2023
@black-coda
Copy link

Please, any luck with the configuration

@adil192
Copy link
Author

adil192 commented Oct 23, 2023

Not yet, we need invertase/flutterfire_cli#219.
There's probably a way to get all the information for FirebaseOptions to do it yourself, but that's beyond me

@firebase firebase locked and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers resolution: solution-provided A solution has been provided in the issue. type: documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants