-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for _userAccessGroup being nil when getStoredUserForAccessGroup is called #7472
Conversation
updating to latest firebase master
…sGroup is called, because otherwise on first app launch, _userAccessGroup will be null, making it impossible for the app to find the shared keychain
@joehinkle11 Thanks for the fix and PR. @rosalyntan Please take a look. Note the CI failure can be disregarded. (#7476) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding and fixing this issue! Your fix should work, but I took a look into the code, and I think you'll actually want to make a change in
user = [self.storedUserManager getStoredUserForAccessGroup:self.userAccessGroup |
accessGroup
rather than self.userAccessGroup
there.
@rosalyntan updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
Irony: react-native-firebase was inadvertently relying on the old behavior in our E2E test suite, and now that this is working our test suite broke when I attempted to adopt v7.8.0. To be clear: as far as I can tell our test suite was not using the API correctly, but the way unintended consequences ripple out always fascinates me. Cheers all |
@mikehardy Glad I was a service in breaking something 😅 |
Breaking Stuff as a Service ;-) |
This is a small change which fixes a significant bug. Basically the app doesn't let users share access groups until second launch
To reproduce:
The cause:
_userAccessGroup
is set AFTERgetStoredUserForAccessGroup
is called, andgetStoredUserForAccessGroup
depends on_userAccessGroup
not being nullSolution: swap the order of when
_userAccessGroup
is set and whengetStoredUserForAccessGroup
is called