GHA zip workflow: add manual trigger #7450
Conversation
|
The updated package step triggered the correct command for non-manual run: https://github.com/firebase/firebase-ios-sdk/runs/1826829858?check_suite_focus=true#step:4:12 |
| custom_spec_repos: | ||
| description: 'Custom Podspec repos' | ||
| required: true | ||
| default: 'https://cpdc-internal.git.corp.google.com/firebase.git' |
There was a problem hiding this comment.
I don't think GHA has access to https://cpdc-internal.git.corp.google.com. I believe we need the whole staging process to SpecsStaging or another public repo.
There was a problem hiding this comment.
Yeah, I would prefer moving release staging to GitHub to simplify GHA access control. I think we can address it in following PRs. For now I would like to test the manual trigger in general.
| @@ -37,7 +44,7 @@ jobs: | |||
| - name: ZipBuildingTest | |||
| run: | | |||
| mkdir -p zip_output_dir | |||
There was a problem hiding this comment.
Add an xcode-select command to Xcode 12.0
There was a problem hiding this comment.
I would prefer to add it in a separate PR. With the manual trigger testing will be so much easier :).
An attempt to add a manual trigger for zip GHA workflow.
I was not able to test the trigger itself as the "Run workflow" button didn't appear for me. I guess the change has to land to the default branch to be picked up by GHA.