Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coverage workflow #7430

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Update coverage workflow #7430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b558bc
Trigger a workflow when a pr is created.
granluo Feb 2, 2021
9d81493
Remove redundant comments and update variables.
granluo Feb 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/test_coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@ name: test_coverage

on:
pull_request:
# open will be triggered when a pull request is created.
# synchronize will be triggered when a pull request has new commits.
# closed will be triggered when a pull request is closed.
types: [synchronize, closed]
types: [open, synchronize, closed]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synchronize will only trigger a workflow when an existing PR is updated.


jobs:
check:
Expand Down
4 changes: 1 addition & 3 deletions .../generate_code_coverage_report/Sources/CoverageReportGenerator/CoverageReportParser.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ extension CoverageReportRequestData {
// FirebaseDatabase-ios-FirebaseCore.framework, a regex pattern will be
// used to exclude results that are not related in terms of the target names.
let sdk_name = resultBundle.components(separatedBy: "-")[0]
let range = NSRange(location: 0, length: sdk_name.utf16.count)
let range = NSRange(location: 0, length: target.name.utf16.count)
Copy link
Contributor Author

@granluo granluo Feb 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bug is detected here. This is caused by the range not aligned with the target.name in line 75.

let sdk_related_coverage_file_pattern = try! NSRegularExpression(
pattern: ".*\(sdk_name).*",
options: NSRegularExpression.Options(rawValue: 0)
Expand All @@ -78,8 +78,6 @@ extension CoverageReportRequestData {
value: target.lineCoverage))
for file in target.files {
results
// .append(FileCoverage(sdk: resultBundle + "-" + target.name + "(Coverage:\(String(format:"%.2f%%", target.lineCoverage*100)))", type: file.name,
// value: file.lineCoverage))
.append(FileCoverage(sdk: resultBundle + "-" + target.name, type: file.name,
value: file.lineCoverage))
results
Expand Down