From 7b558bc21782be70807eb3a8aff909c0ea596ddc Mon Sep 17 00:00:00 2001 From: Gran Luo Date: Tue, 2 Feb 2021 11:13:59 -0800 Subject: [PATCH 1/2] Trigger a workflow when a pr is created. --- .github/workflows/test_coverage.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test_coverage.yml b/.github/workflows/test_coverage.yml index a81a069ded5..22d7c406370 100644 --- a/.github/workflows/test_coverage.yml +++ b/.github/workflows/test_coverage.yml @@ -2,9 +2,10 @@ name: test_coverage on: pull_request: + # open will be triggered when a pull request is created. # synchronize will be triggered when a pull request has new commits. # closed will be triggered when a pull request is closed. - types: [synchronize, closed] + types: [open, synchronize, closed] jobs: check: From 9d81493da754e08db88de34c192cb43a0c8c50f3 Mon Sep 17 00:00:00 2001 From: Gran Luo Date: Tue, 2 Feb 2021 11:55:05 -0800 Subject: [PATCH 2/2] Remove redundant comments and update variables. --- .../CoverageReportGenerator/CoverageReportParser.swift | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/scripts/code_coverage_report/generate_code_coverage_report/Sources/CoverageReportGenerator/CoverageReportParser.swift b/scripts/code_coverage_report/generate_code_coverage_report/Sources/CoverageReportGenerator/CoverageReportParser.swift index f81233f01c4..073b79f9b4a 100644 --- a/scripts/code_coverage_report/generate_code_coverage_report/Sources/CoverageReportGenerator/CoverageReportParser.swift +++ b/scripts/code_coverage_report/generate_code_coverage_report/Sources/CoverageReportGenerator/CoverageReportParser.swift @@ -66,7 +66,7 @@ extension CoverageReportRequestData { // FirebaseDatabase-ios-FirebaseCore.framework, a regex pattern will be // used to exclude results that are not related in terms of the target names. let sdk_name = resultBundle.components(separatedBy: "-")[0] - let range = NSRange(location: 0, length: sdk_name.utf16.count) + let range = NSRange(location: 0, length: target.name.utf16.count) let sdk_related_coverage_file_pattern = try! NSRegularExpression( pattern: ".*\(sdk_name).*", options: NSRegularExpression.Options(rawValue: 0) @@ -78,8 +78,6 @@ extension CoverageReportRequestData { value: target.lineCoverage)) for file in target.files { results - // .append(FileCoverage(sdk: resultBundle + "-" + target.name + "(Coverage:\(String(format:"%.2f%%", target.lineCoverage*100)))", type: file.name, - // value: file.lineCoverage)) .append(FileCoverage(sdk: resultBundle + "-" + target.name, type: file.name, value: file.lineCoverage)) results