Update coverage workflow #7430
Merged
Update coverage workflow #7430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
granluo
commented
Feb 2, 2021
| @@ -66,7 +66,7 @@ extension CoverageReportRequestData { | |||
| // FirebaseDatabase-ios-FirebaseCore.framework, a regex pattern will be | |||
| // used to exclude results that are not related in terms of the target names. | |||
| let sdk_name = resultBundle.components(separatedBy: "-")[0] | |||
| let range = NSRange(location: 0, length: sdk_name.utf16.count) | |||
| let range = NSRange(location: 0, length: target.name.utf16.count) | |||
There was a problem hiding this comment.
This bug is detected here. This is caused by the range not aligned with the target.name in line 75.
granluo
commented
Feb 2, 2021
| # synchronize will be triggered when a pull request has new commits. | ||
| # closed will be triggered when a pull request is closed. | ||
| types: [synchronize, closed] | ||
| types: [open, synchronize, closed] |
There was a problem hiding this comment.
Synchronize will only trigger a workflow when an existing PR is updated.
paulb777
approved these changes
Feb 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trigger the code coverage workflow when a PR is created. Fix a bug and remove redundant comments.