Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add secret to performance integration tests. #7169

Merged
merged 7 commits into from
Dec 15, 2020
Merged

Add secret to performance integration tests. #7169

merged 7 commits into from
Dec 15, 2020

Conversation

jeremyjiang-dev
Copy link
Contributor

@jeremyjiang-dev jeremyjiang-dev commented Dec 15, 2020 •
edited
Loading

Summary:

  • Read E2E Test App GoogleService-Info.plist from encrypted file.
  • Remove GoogleService-Info.plist for dev test App.

Successful runs: https://github.com/firebase/firebase-ios-sdk/actions/runs/423619208

@google-cla google-cla bot added the cla: yes label Dec 15, 2020
@jeremyjiang-dev jeremyjiang-dev marked this pull request as ready for review December 15, 2020 18:29
@jeremyjiang-dev jeremyjiang-dev merged commit 342314d into master Dec 15, 2020
@jeremyjiang-dev jeremyjiang-dev deleted the perf-e2e branch December 15, 2020 20:04
@firebase firebase locked and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@visumickey visumickey visumickey approved these changes

@zijianjoy zijianjoy zijianjoy approved these changes

Assignees
No one assigned
Labels
api: performance cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeremyjiang-dev @paulb777 @visumickey @zijianjoy