Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly segmentation and include performance in report #7151

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

paulb777
Copy link
Member

Fix nightly segmentation failure and add performance to the report

The segmentation failure did not show up in #7149. @granluo, any ideas why?

@paulb777 paulb777 merged commit c9d4650 into master Dec 14, 2020
@paulb777 paulb777 deleted the pb-fix-nightly branch December 14, 2020 15:37
@granluo
Copy link
Contributor

granluo commented Dec 17, 2020

Sorry for the delay, might need to reset the github notification. It turns out Github Workflow APIs has a page parameter which will display 30 workflows by default. We have 37 workflows in total based on the record I get from the API. Segmentation is in the second page, so that is why it is not shown. I will update the tool to fix it then.

@firebase firebase locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants