Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back the changes of reading the version from FIRCore with fixes + unit test. #6958

Merged
merged 6 commits into from
Nov 11, 2020
Merged

Bring back the changes of reading the version from FIRCore with fixes + unit test. #6958

merged 6 commits into from
Nov 11, 2020

Conversation

tejasd
Copy link
Contributor

@tejasd tejasd commented Nov 11, 2020

#no-changelog

@google-cla google-cla bot added the cla: yes label Nov 11, 2020
@tejasd tejasd requested a review from samedson November 11, 2020 19:05
samedson
samedson approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@samedson samedson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing 👍

@tejasd tejasd mentioned this pull request Nov 11, 2020
Merged
@tejasd tejasd merged commit 6de9131 into master Nov 11, 2020
@firebase firebase locked and limited conversation to collaborators Dec 12, 2020
@paulb777 paulb777 deleted the td/crashlytics-1p-3 branch January 28, 2021 04:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samedson samedson samedson approved these changes

Assignees
No one assigned
Labels
api: crashlytics cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tejasd @samedson @google-oss-bot