Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Performance podspec #6526

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Add Performance podspec #6526

merged 1 commit into from
Sep 25, 2020

Conversation

paulb777
Copy link
Member

Enable more shared test and release processes between binary and source pods.

#no-changelog

Copy link
Contributor

@visumickey visumickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are we planning to have this updated on a regular basis? Is this planned to be updated as a part of every release?

@paulb777
Copy link
Member Author

Yep, the proposed process is that your team updates the source field of the podspec by code freeze if you want to make an update and the iCore team manages the versioning and release from there.

@visumickey
Copy link
Contributor

Yep, the proposed process is that your team updates the source field of the podspec by code freeze if you want to make an update and the iCore team manages the versioning and release from there.

Thanks Paul.

Just to clarify - Perf team, when we plan to make a release, we make changes to the podspec in the "FirebasePrivate/perf" branch and we also make the change to this public podspec? Want to make sure I update the steps for making a release from private Github.

@paulb777
Copy link
Member Author

paulb777 commented Sep 25, 2020

Confirmed.

After the next release, we'll stop managing releases via spreadsheet and the GitHub master branch becomes the only mechanism for identifying what is part of a release.

@paulb777 paulb777 merged commit d248d8d into master Sep 25, 2020
@paulb777 paulb777 deleted the pb-perf-podspec branch September 25, 2020 14:52
christibbs pushed a commit that referenced this pull request Sep 28, 2020
@firebase firebase locked and limited conversation to collaborators Oct 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants