Refactoring archive testing to a single yml file. #6510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the duplication in each of the workflow files. This also will make archive testing with SwiftPM more straightforward.
paulb777
reviewed
Sep 21, 2020
.github/workflows/archiving.yml
Outdated
| # Archive tests for pods that support iOS only. | ||
| pods-ios-only-cron: | ||
| # Don't run on private repo. | ||
| if: github.event_name == 'schedule' && github.repository != 'FirebasePrivate/firebase-ios-sdk' |
There was a problem hiding this comment.
Would you comment this to test?
.github/workflows/archiving.yml
Outdated
| # Archive tests for pods that support iOS, tvOS, and macOS. | ||
| pods-ios-tvos-macos-cron: | ||
| # Don't run on private repo. | ||
| if: github.event_name == 'schedule' && github.repository != 'FirebasePrivate/firebase-ios-sdk' |
|
remoteconfig test failure is addressed by #6514 |
The yml won't be parsed unless the `pod` array is on a single line.
Thanks, got caught with a |
paulb777
approved these changes
Sep 24, 2020
christibbs
pushed a commit
that referenced
this pull request
Sep 28, 2020
* Refactoring archive testing to a single yml file. This reduces the duplication in each of the workflow files. This also will make archive testing with SwiftPM more straightforward. * Prefixed with 'pod' name * Commenting out to run archive testing on PR for now. * Put array on single line The yml won't be parsed unless the `pod` array is on a single line. * Fix to run on PRs to the yml itself. * Fix naming of AppDistro * Remove schemes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the duplication in each of the workflow files. This also
will make archive testing with SwiftPM more straightforward.