-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release candidate prerelease workflow. #6487
Conversation
The release-6.33.0 branch has an unreleased FirebaseAnalytics sdk, which is updated to a released one so the spec repo could be built. |
.github/workflows/prerelease.yml
Outdated
run: | | ||
pod repo remove "${local_repo}" | ||
rm -rf bot-access.txt | ||
remoteconfig_quickstart: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: blank line before
.github/workflows/prerelease.yml
Outdated
run: | | ||
pod repo remove "${local_repo}" | ||
rm -rf bot-access.txt | ||
remoteconfig_quickstart: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sort remoteconfig
.github/workflows/prerelease.yml
Outdated
pod repo remove "${local_repo}" | ||
rm -rf bot-access.txt | ||
remoteconfig_quickstart: | ||
# Don't run on private repo unless it is a PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would require a few special case tests, but wondering if we should to all the jobs via one matrixed job?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some experiments and it turns out we might need to update scripts to have matrix. E.g. Crashlytics need to have two binaries,run and upload-symbols. Also, some tests have objc while some do not have. I think we might submit this pr to run prerelease test first, and another pr to refactor nightly release and prerelease workflows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on green
Sources of release/prerelease tests are updated to cocoapods repo from cdn and tests are passed. The failed test is caused by cdn. The workflow works fine and will push. |
This also update cocoapods source to cocoapods repo since cdn is failed to connect.
No description provided.