Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release candidate prerelease workflow. #6487

Merged
merged 40 commits into from
Sep 23, 2020
Merged

Conversation

granluo
Copy link
Contributor

@granluo granluo commented Sep 17, 2020

No description provided.

@granluo granluo marked this pull request as ready for review September 18, 2020 21:57
@granluo
Copy link
Contributor Author

granluo commented Sep 18, 2020

The release-6.33.0 branch has an unreleased FirebaseAnalytics sdk, which is updated to a released one so the spec repo could be built.

run: |
pod repo remove "${local_repo}"
rm -rf bot-access.txt
remoteconfig_quickstart:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: blank line before

run: |
pod repo remove "${local_repo}"
rm -rf bot-access.txt
remoteconfig_quickstart:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort remoteconfig

pod repo remove "${local_repo}"
rm -rf bot-access.txt
remoteconfig_quickstart:
# Don't run on private repo unless it is a PR.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would require a few special case tests, but wondering if we should to all the jobs via one matrixed job?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some experiments and it turns out we might need to update scripts to have matrix. E.g. Crashlytics need to have two binaries,run and upload-symbols. Also, some tests have objc while some do not have. I think we might submit this pr to run prerelease test first, and another pr to refactor nightly release and prerelease workflows.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@granluo
Copy link
Contributor Author

granluo commented Sep 23, 2020

Sources of release/prerelease tests are updated to cocoapods repo from cdn and tests are passed. The failed test is caused by cdn. The workflow works fine and will push.

@granluo granluo merged commit 9f8d395 into master Sep 23, 2020
@granluo granluo deleted the add_prerelease_workflow branch September 23, 2020 17:40
christibbs pushed a commit that referenced this pull request Sep 28, 2020
This also update cocoapods source to cocoapods repo since cdn is failed to connect.
@firebase firebase locked and limited conversation to collaborators Oct 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants