Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated sendLogsWithServiceName #6437

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Remove deprecated sendLogsWithServiceName #6437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions FirebaseCore/Sources/FIRApp.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -897,17 +897,6 @@ + (nullable NSNumber *)readDataCollectionSwitchFromPlist {
return collectionEnabledPlistObject;
}

#pragma mark - Sending Logs

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wunused-parameter"
- (void)sendLogsWithServiceName:(NSString *)serviceName
version:(NSString *)version
error:(NSError *)error {
// Do nothing. Please remove calls to this method.
}
#pragma clang diagnostic pop

#pragma mark - App Life Cycle

- (void)subscribeForAppDidBecomeActiveNotifications {
Expand Down
9 changes: 0 additions & 9 deletions FirebaseCore/Sources/Private/FIRAppInternal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,15 +144,6 @@ extern NSString *const FIRAuthStateDidChangeInternalNotificationUIDKey;
*/
+ (NSString *)firebaseUserAgent;

/**
* Used by each SDK to send logs about SDK configuration status to Clearcut.
*
* @note This API is a no-op, please remove calls to it.
*/
- (void)sendLogsWithServiceName:(NSString *)serviceName
version:(NSString *)version
error:(NSError *)error;

/**
* Can be used by the unit tests in eack SDK to reset FIRApp. This method is thread unsafe.
*/
Expand Down