Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky installation of GoogleAppMeasurement in 7.11 with SwiftPM #7962

Closed
ryanwilson opened this issue Apr 26, 2021 · 6 comments
Closed

Flaky installation of GoogleAppMeasurement in 7.11 with SwiftPM #7962

ryanwilson opened this issue Apr 26, 2021 · 6 comments

Comments

@ryanwilson
Copy link
Member

[REQUIRED] Step 1: Describe your environment

  • Xcode version: 12.5
  • Firebase SDK version: 7.11.0
  • Installation method: Swift Package Manager
  • Firebase Component: Analytics

[REQUIRED] Step 2: Describe the problem

Steps to reproduce:

From a blank project in Xcode 12.5, attempt to add Firebase via SwiftPM.
Occasionally, this fails to reproduce with the message:

artifact of binary target 'GoogleAppMeasurement' failed extraction: The operation couldn't be completed. (TSCBasic.StringError error 1.)
artifact of binary target 'GoogleAppMeasurementWithoutAdIdSupport' failed extraction: The operation couldn't be completed. (TSCBasic.StringError error 1.)

Relevant Code:

No code needed, error occurs in Xcode during installation.

Screenshot of error in Xcode

@ryanwilson
Copy link
Member Author

This is likely the underlying implementation of the unzipping:
https://github.com/apple/swift-tools-support-core/blob/435a2708a6e486d69ea7d7aaa3f4ad243bc3b408/Sources/TSCUtility/Archiver.swift#L65

Will try to work off that and reproduce.

@ryanwilson
Copy link
Member Author

Using the unzip command an extra directory __MACOSX shows up. I suspect this is due to an incorrect compression of the release artifacts, and Xcode gets confused when there are 2 XCFrameworks nested there. This could also explain the flakiness in that sometimes the proper XCFramework gets selected.

Duplicate folders in finder

ryanwilson added a commit to google/GoogleAppMeasurement that referenced this issue Apr 26, 2021
This includes the same artifacts as 7.11.0 but put into the proper `.zip` format (with `zip` on the command line instead of Finder's compress menu option).

See firebase/firebase-ios-sdk#7962 for more details.
ryanwilson added a commit to google/GoogleAppMeasurement that referenced this issue Apr 26, 2021
This includes the same artifacts as 7.11.0 but put into the proper `.zip` format (with `zip` on the command line instead of Finder's compress menu option).

See firebase/firebase-ios-sdk#7962 for more details.
@ryanwilson
Copy link
Member Author

7.11.1 for SwiftPM was released and this appears to be resolved.

@morganchen12
Copy link
Contributor

@ryanwilson does this warrant a release note?

@ryanwilson ryanwilson reopened this Apr 28, 2021
@ryanwilson
Copy link
Member Author

@ryanwilson does this warrant a release note?

Probably - but let's hold off momentarily as I just had the issue happen again.

@paulb777
Copy link
Member

paulb777 commented Jun 4, 2021

This seems to have stabilized with some combination of recent Xcodes and Firebase releases. I'll close for now and we can reopen if it reoccurs.

@paulb777 paulb777 closed this as completed Jun 4, 2021
@firebase firebase locked and limited conversation to collaborators Jul 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants