Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_coverage workflow fails on external PRs #7476

Closed
paulb777 opened this issue Feb 8, 2021 · 8 comments · Fixed by #7484 or #8246
Closed

test_coverage workflow fails on external PRs #7476

paulb777 opened this issue Feb 8, 2021 · 8 comments · Fixed by #7484 or #8246
Assignees

Comments

@paulb777
Copy link
Member

paulb777 commented Feb 8, 2021

See #7472

The test_coverage workflow should either be disabled or made to work for PRs from forked repos.

@granluo
Copy link
Contributor

granluo commented Feb 8, 2021

If secrets are not able to be accessed, then Metrics Service cannot be used and so code coverage report is not able to be created. To avoid failing test workflows, we might need to disable this workflows under certain situations.
I made some experiments and it looks like the sdk repo can run workflows from a forked repo, not sure if secrets can be used or not yet. Will make more experiments.

@granluo granluo linked a pull request Feb 9, 2021 that will close this issue
@paulb777
Copy link
Member Author

Reopening. Still seeing failures in #7507

@paulb777
Copy link
Member Author

@granluo
Copy link
Contributor

granluo commented Feb 18, 2021

Have test on a fork repo. The corresponding step is in the step check files of the job Check changed files
https://github.com/firebase/firebase-ios-sdk/runs/1929701292?check_suite_focus=true

The failure is probably caused by that fork repo not syncing to the upstream yet.

@paulb777
Copy link
Member Author

I see thanks.

@firebase firebase locked and limited conversation to collaborators Mar 23, 2021
@paulb777
Copy link
Member Author

paulb777 commented Apr 24, 2021

@paulb777 paulb777 reopened this Apr 24, 2021
@firebase firebase unlocked this conversation Apr 24, 2021
elenadoty pushed a commit that referenced this issue Jun 1, 2021
…8162)

(Note that failing test is expected for external prs (#7476).)
@granluo granluo linked a pull request Jun 11, 2021 that will close this issue
@firebase firebase locked and limited conversation to collaborators Jul 13, 2021
@paulb777
Copy link
Member Author

paulb777 commented Aug 3, 2021

@granluo This is still failing in #8483 and #8484. Please test on a forked PR. Reopening.

@paulb777 paulb777 reopened this Aug 3, 2021
@paulb777
Copy link
Member Author

There is still a post-submit issue, but that's not a big deal. I'll close since presubmits are now working.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants