Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: Add ServerTimestampBehavior option to FirebaseFirestoreSwift #6328

Closed
nathanvogel opened this issue Aug 25, 2020 · 2 comments · Fixed by #6334
Closed

FR: Add ServerTimestampBehavior option to FirebaseFirestoreSwift #6328

nathanvogel opened this issue Aug 25, 2020 · 2 comments · Fixed by #6334
Labels
api: firestore type: feature request

Comments

@nathanvogel
Copy link

Feature proposal

  • Firebase Component: FirebaseFirestoreSwift.

These are the currently available methods to get data from a document, if FirebaseFirestoreSwift is installed:

Screenshot 2020-08-25 at 11 16 03

I would expect these additional methods, so that all use cases are covered:

data(as: Decodable.Protocol, with: ServerTimestampBehavior) throws
data(as: Decodable.Protocol, with: ServerTimestampBehavior, decoder: Firestore.Decoder?) throws

This would also go towards feature parity with the Kotlin Android SDK.

Thank you,
Cheers
@wilhuff
Copy link
Contributor

wilhuff commented Aug 25, 2020

This is an oversight and we'll put this together. Thanks for pointing it out!

@nathanvogel
Copy link
Author

Glad to read it, thanks!

wilhuff added a commit that referenced this issue Aug 25, 2020
@wilhuff
Add DocumentSnapshot.data(as:with:decoder:)
2552cd5 
This adds support for specifying alternative server timestamp behaviors
when decoding snapshots.

Fixes #6328.
wilhuff added a commit that referenced this issue Aug 25, 2020
@wilhuff
Add DocumentSnapshot.data(as:with:decoder:)
f7fe18e 
This adds support for specifying alternative server timestamp behaviors
when decoding snapshots.

Fixes #6328.
@wilhuff wilhuff mentioned this issue Aug 25, 2020
Merged
wilhuff added a commit that referenced this issue Feb 5, 2021
@wilhuff
Add DocumentSnapshot.data(as:with:decoder:) (#6334)
8d92434 
This adds support for specifying alternative server timestamp behaviors
when decoding snapshots.

Fixes #6328.
@firebase firebase locked and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
api: firestore type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add DocumentSnapshot.data(as:with:decoder:) firebase/firebase-ios-sdk
3 participants
@nathanvogel @morganchen12 @wilhuff