Skip to content

Commit

Permalink
fix for _userAccessGroup being nil when getStoredUserForAccessGroup i…
Browse files Browse the repository at this point in the history
…s called (#7472)

* shareLoginAcrossDevices

* shareLoginAcrossDevices

* shareLoginAcrossDevices

* shareLoginAcrossDevices

* formatting

* feedback changes

* linted

* setting _userAccessGroup needs to happen before getStoredUserForAccessGroup is called, because otherwise on first app launch, _userAccessGroup will be null, making it impossible for the app to find the shared keychain

* proper fix as suggested by rosalyntan
  • Loading branch information
joehinkle11 authored Mar 2, 2021
1 parent 35b4210 commit b807226
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion FirebaseAuth/Sources/Auth/FIRAuth.m
Original file line number Diff line number Diff line change
Expand Up @@ -2258,7 +2258,7 @@ - (nullable FIRUser *)getStoredUserForAccessGroup:(NSString *_Nullable)accessGro
#endif // TARGET_OS_WATCH
user = [unarchiver decodeObjectOfClass:[FIRUser class] forKey:userKey];
} else {
user = [self.storedUserManager getStoredUserForAccessGroup:self.userAccessGroup
user = [self.storedUserManager getStoredUserForAccessGroup:accessGroup
shareAuthStateAcrossDevices:self.shareAuthStateAcrossDevices
projectIdentifier:self.app.options.APIKey
error:outError];
Expand Down

0 comments on commit b807226

Please sign in to comment.