Skip to content

Commit

Permalink
Rename CRASHLYTICS_INTERNAL to CRASHLYTICS_1P (#6957)
Browse files Browse the repository at this point in the history
  • Loading branch information
tejasd authored Nov 11, 2020
1 parent 6e5f02d commit 41c612b
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ + (BOOL)isCrashlyticsCollectionEnabledWithApp:(FIRApp *)app withAppInfo:(NSDicti
[firebaseCrashlyticsCollectionEnabled isKindOfClass:[NSNumber class]]) {
return [firebaseCrashlyticsCollectionEnabled boolValue];
}
#ifdef CRASHLYTICS_INTERNAL
#ifdef CRASHLYTICS_1P
return NO;
#else
return [app isDataCollectionDefaultEnabled];
Expand Down
2 changes: 1 addition & 1 deletion Crashlytics/Crashlytics/Models/FIRCLSSettings.m
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ - (BOOL)collectReportsEnabled {
}

- (BOOL)shouldUseNewReportEndpoint {
#ifdef CRASHLYTICS_INTERNAL
#ifdef CRASHLYTICS_1P
return YES;
#else
NSNumber *value = [self appSettings][@"report_upload_variant"];
Expand Down
2 changes: 1 addition & 1 deletion Crashlytics/UnitTests/FIRCLSDataCollectionArbiterTest.m
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ - (void)tearDown {
- (void)testNothingSet {
self.fakeApp.isDefaultCollectionEnabled = YES;
FIRCLSDataCollectionArbiter *arbiter = [self arbiterWithDictionary:@{}];
#ifdef CRASHLYTICS_INTERNAL
#ifdef CRASHLYTICS_1P
XCTAssertFalse([arbiter isCrashlyticsCollectionEnabled]);
#else
// It should be YES by default for 3P users.
Expand Down
2 changes: 1 addition & 1 deletion Crashlytics/UnitTests/FIRCLSSettingsTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ - (void)testLegacyReportEndpointSettings {
[self.settings cacheSettingsWithGoogleAppID:TestGoogleAppID currentTimestamp:currentTimestamp];

XCTAssertNil(error, "%@", error);
#ifdef CRASHLYTICS_INTERNAL
#ifdef CRASHLYTICS_1P
XCTAssertTrue(self.settings.shouldUseNewReportEndpoint);
#else
XCTAssertFalse(self.settings.shouldUseNewReportEndpoint);
Expand Down

0 comments on commit 41c612b

Please sign in to comment.