FDL getDynamicLink(Intent) method to accept null intent. #2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with the documentation and since the intent is not a must parameter to derive the pending FDL.
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (72c18d1e) is created by Prow via merging commits: 3f0779e b576ecd. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (72c18d1e) is created by Prow via merging commits: 3f0779e b576ecd. |
|
Is this PR still required or is it superseded by the recent FDL update? |
@vkryachko It is still an issue in 20.1.0 |
vkryachko
approved these changes
Sep 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the @nonnull to @nullable for
Intentargument in getDynamicLink(intent) method.The intent parameter should be the intent that launched the application, or can be null if the intent does not include the dynamic link. A non-null intent is necessary only when the app is launched directly using the dynamic link, such as when using App Links.
Changes:
Related issue: #2336