Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use objective-c++ compatible import statements #891

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Use objective-c++ compatible import statements #891

merged 1 commit into from
Aug 11, 2020

Conversation

audkar
Copy link
Contributor

@audkar audkar commented Aug 11, 2020 •
edited
Loading

Fixes issue #875

note: I don't know what I am doing, please check carefully for potential problems (zero objective-c knowledge)

@audkar audkar changed the title Use object-c++ compatible import statements Use objective-c++ compatible import statements Aug 11, 2020
morganchen12
morganchen12 approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@morganchen12 morganchen12 merged commit 06e6d70 into firebase:master Aug 11, 2020
@audkar audkar deleted the replace-imports branch August 11, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morganchen12 morganchen12 morganchen12 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@audkar @morganchen12 @googlebot