Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align GitHub's best practices for rate limits #64

Closed
pbrudnick opened this issue Apr 6, 2020 · 1 comment · Fixed by #90
Closed

Align GitHub's best practices for rate limits #64

pbrudnick opened this issue Apr 6, 2020 · 1 comment · Fixed by #90

Comments

@pbrudnick
Copy link
Member

https://developer.github.com/v3/guides/best-practices-for-integrators/#dealing-with-abuse-rate-limits

https://developer.github.com/v3/#abuse-rate-limits

There are 2 points where we need to work:

Make requests for a single user or client ID serially. Do not make requests for a single user or client ID concurrently.

When you have been limited, use the Retry-After response header to slow down. The value of the Retry-After header will always be an integer, representing the number of seconds you should wait before making requests again. For example, Retry-After: 30 means you should wait 30 seconds before sending more requests.

@pbrudnick
Copy link
Member Author

Make requests for a single user or client ID serially. Do not make requests for a single user or client ID concurrently.

Rolled back to sync requests here:
#67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant