Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with paths containing spaces, or the . directory #53

Closed
RISCfuture opened this issue Apr 29, 2020 · 6 comments · Fixed by #54
Closed

Doesn't work with paths containing spaces, or the . directory #53

RISCfuture opened this issue Apr 29, 2020 · 6 comments · Fixed by #54

Comments

@RISCfuture
Copy link

RISCfuture commented Apr 29, 2020

The following invocations fail with "invalid value for dependency" or "invalid value for output":

arena -o . some/dependency
arena -o some\ output/path some/dependency
arena -o some/output/path some\ dependency/path
arena -o "some output/path" some/dependency
arena -o some/output/path "some dependency/path"

@finestructure
Copy link
Owner

Ah, good find - I'l need to check the path escaping...

The first one is technically redundant, as "." is the default (and if you want to be explicit you can use -o $PWD for now. Still "." should work though :)

Thanks for raising the issue!

@robbiemu
Copy link

robbiemu commented May 2, 2020

also doesn't work for paths containing a space:

MacBook-Pro:swift robertotomas$ arena https://github.com/Jounce/Surge
➡️  Package: https://github.com/Jounce/Surge @ from(2.3.0)
🔧 Resolving package dependencies ...
📔 Libraries found: Surge
🔨 Building package dependencies ...
✅ Created project in folder 'Arena-Playground'
Error: ShellOut encountered an error
Status code: 1
Message: "The files /Users/robertotomas/Public/Neural, /Users/robertotomas/Public/Neural Networks from Scratch/swift/Networks, /Users/robertotomas/Public/Neural Networks from Scratch/swift/from, and /Users/robertotomas/Public/Neural Networks from Scratch/swift/Scratch/swift/Arena-Playground/Arena-Playground.xcworkspace do not exist."
Output: ""
MacBook-Pro:swift robertotomas$ pwd
/Users/robertotomas/Public/Neural Networks from Scratch/swift

@finestructure
Copy link
Owner

I've just pushed 0.16.1 which should fix these issue. Please update via

brew upgrade arena

and let me know if you're still seeing issues!

@finestructure
Copy link
Owner

@robbiemu I've just realised you were reporting a different issue - with a path with whitespace within a package.

This is actually not yet fixed in 0.16.1. I can reproduce it and will push 0.16.2.

@finestructure
Copy link
Owner

Actually, I take that back. It can launch that repository just fine now:

❯ arena https://github.com/Jounce/Surge@from:2.3.0 -f
➡️  Package: https://github.com/Jounce/Surge @ from(2.3.0)
🔧 Resolving package dependencies ...
📔 Libraries found: Surge
🔨 Building package dependencies ...
✅ Created project in folder 'Arena-Playground'

The error I was getting was due to a network issue.

@robbiemu
Copy link

robbiemu commented May 2, 2020

actually it seems like that did it, I can now build, ⌘+B and run directly .. I bet there was more in your change than just that path!

edit: yes, even now I can directly just do arena Jounce/Surge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants