Add error handling and specify encodings. #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
danieldk
approved these changes
Jun 9, 2020
src/finalfusion/scripts/util.py
Outdated
| action="store_true", | ||
| default=False, | ||
| help= | ||
| "Whether to fail on malformed UTF8. Setting this flag replaces malformed UTF8" |
src/finalfusion/compat/text.py
Outdated
| Path to a file with embeddings in word2vec binary format. | ||
| Path to a file with embeddings in text format with dimensions on the first line. | ||
| lossy : bool | ||
| If set to true, malformed UTF8 sequences in words will be replaced with the `U+FFFD` |
src/finalfusion/compat/text.py
Outdated
| @@ -57,14 +64,18 @@ def load_text(file: Union[str, bytes, int, PathLike]) -> Embeddings: | |||
| ---------- | |||
| file : str, bytes, int, PathLike | |||
| Path to a file with embeddings in word2vec binary format. | |||
| lossy : bool | |||
| If set to true, malformed UTF8 sequences in words will be replaced with the `U+FFFD` | |||
src/finalfusion/compat/word2vec.py
Outdated
| @@ -30,6 +31,9 @@ def load_word2vec(file: Union[str, bytes, int, PathLike]) -> Embeddings: | |||
| ---------- | |||
| file : str, bytes, int, PathLike | |||
| Path to a file with embeddings in word2vec binary format. | |||
| lossy : bool | |||
| If set to true, malformed UTF8 sequences in words will be replaced with the `U+FFFD` | |||
|
Thanks, fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some noise from refactoring the scripts, mostly due the odd design of
Format.{to, from}.