Implement Analogies & Similarities

[sebpuetz]

No description provided.

[danieldk]

I think once we have these, the functionality should be equivalent to the Rust Python module, right? I guess we could then have it replace the Rust flavor in PyPi (and thus become version 0.7.0).

[sebpuetz]

Almost - I didn't finish overhauling the quantization module yet. After doing that, this should be on par and we can put it on PyPi as finalfusion-python.

Although, I think it'd be nice to get the documentation done before that, too. That also mostly exists, it's mostly about adjusting to changes made from my ffp repo vs. the reworked package here.

How should we go about organizing the repos? Renaming finalfusion/finalfusion-python doesn't seem justified, moving this repo's master to finalfusion-python master means losing the history in PR & issues. So I guess one solution is archiving finalfusion-python and leaving the name of this repo as-is while publishing as finalfusion?

Edit: There's also some inconsistent treatment wrt. normalization and some central methods that are typed as Any which messes up the type checks in various places. Might make sense to fix that, too.

[danieldk]

How should we go about organizing the repos? Renaming finalfusion/finalfusion-python doesn't seem justified, moving this repo's master to finalfusion-python master means losing the history in PR & issues. So I guess one solution is archiving finalfusion-python and leaving the name of this repo as-is while publishing as finalfusion?

I think for compatibility it would be nice if it was possible to at least be able to get old commits from finalfusion-python (for reproducibility). One solution would be to rename the current branch something like old-rust and then import the history of this repository (ffp) as the new master branch. The downside is of course that any issues/PRs mentioned in in the commits in this repo would become invalid. I guess this is a downside of GitHub not treating issues/PRs as first-class git objects.

Edit: seems like there are no such references in commit messages yet.

Archiving would indeed be another possibility. But then it would probably be nicer to rename this repository to something like finalfusion-python-ng.

[sebpuetz]

How should we go about organizing the repos? Renaming finalfusion/finalfusion-python doesn't seem justified, moving this repo's master to finalfusion-python master means losing the history in PR & issues. So I guess one solution is archiving finalfusion-python and leaving the name of this repo as-is while publishing as finalfusion?

I think for compatibility it would be nice if it was possible to at least be able to get old commits from finalfusion-python (for reproducibility). One solution would be to rename the current branch something like old-rust and then import the history of this repository (ffp) as the new master branch. The downside is of course that any issues/PRs mentioned in in the commits in this repo would become invalid. I guess this is a downside of GitHub not treating issues/PRs as first-class git objects.

Edit: seems like there are no such references in commit messages yet.

I see three options:

1. I only started opening issues very recently here to keep track of what needs to be done. The loss of information by migrating this repo would be only about the PRs. OTOH, I don't find myself regularly looking through old PRs to find some information:

So I guess we could archive finalfusion/ffp and continue development in finalfusion/finalfusion-python?

2. The other way around: Rename and archive finalfusion-python, import the master branch & release tags of finalfusion-python to this repo, add some info to the README about where to find a) the Rusty branch and b) the old repository.

3. Slightly altered second suggestion: Rename and archive finalfusion-python, rewrite this repository's history to be based on finalfusion-python with an additional commit that deletes all rusty content.

This version keeps compatibility if for some reason someone wants to check out a specific commit of the old version. It also keeps the full commit-history of the PyPi finalfusion-python package on a single branch.

After writing this out, I think 2. or 3. don't look too bad. What do you think?

[danieldk]

I like (1) and I am volunteering to do the work, shouldn't take longer than five minutes ;). I'll do it now, and you can see if you like it (I can always revert back).

[sebpuetz]

That's also fine for me, keeps the stars ;)

[danieldk]

Done:

https://github.com/finalfusion/finalfusion-python

Old Rust branch is old-rust.

[sebpuetz]

Fair enough, then let's archive this one, I'll copy the issues later!

[danieldk]

You can even transfer the issues to the other repo nowadays.

[sebpuetz]

I moved the issues & archived finalfusion/ffp