Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download pyo3-pack instead of cargo install #65

Closed
sebpuetz opened this issue Sep 9, 2019 · 2 comments
Closed

Download pyo3-pack instead of cargo install #65

sebpuetz opened this issue Sep 9, 2019 · 2 comments

Comments

@sebpuetz
Copy link
Member

sebpuetz commented Sep 9, 2019

Downloading a precompiled version of pyo3-pack would shave off more than 10 minutes from build times. Any objections to this?

Although it seems like something is messed up for the 0.6.1 binary, at least it's not possible for me to run it locally or on CI. Bash just states, that the file or directory doesn't exist. The newest release works just fine locally.

@danieldk
Copy link
Member

danieldk commented Sep 9, 2019

Although it seems like something is messed up for the 0.6.1 binary, at least it's not possible for me to run it locally or on CI. Bash just states, that the file or directory doesn't exist. The newest release works just fine locally.

Probably because the interpreter path is wrong:

❯ readelf --headers pyo3-pack | grep interpret
      [Requesting program interpreter: /lib/ld64.so.1]

Oddly enough it also wants to link to dbus!:

❯ readelf -d pyo3-pack | grep Shared
 0x0000000000000001 (NEEDED)             Shared library: [libdbus-1.so.3]

I don't know, some weird things seem to happen in these builds. I am move in favor of axing pyo3-pack. On Linux it works perfectly fine without, on macOS you need some extra configuration flag. I'll do a PR.

@sebpuetz
Copy link
Member Author

#67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants