You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
go-filecoin has as number of direct dependencies on parts of libp2p (eg, go-libp2p-peer) and we also depend directly on libp2p. This means that (A) we can have version conflicts where we depend on sub-deps of libp2p that are at a different version than the sub-deps depended on by the version of libp2p that we depend on and (B) we have strictly more direct deps than is necessary. We should just depend on go-libp2p for these things.
I think what needs to happen here is:
for each dependency in common between libp2p and go-filecoin, remove that dependency from go-filecoin's package.json
verify that this works by gx-go rewrite --undo && gx-go rewrite so we can see it picking up the right deps from libp2p
Coming back to this we need to start using gx correctly, incorporating gx-go rewrites into build process for this to start working. The need for this has become clear during latest libp2p update attempt.
this doesn't feel like a priority to fix, i can't imagine us prioritizing it any time soon unless there is real pain, going to close. feel free to reopen if you disagree.
go-filecoin has as number of direct dependencies on parts of libp2p (eg, go-libp2p-peer) and we also depend directly on libp2p. This means that (A) we can have version conflicts where we depend on sub-deps of libp2p that are at a different version than the sub-deps depended on by the version of libp2p that we depend on and (B) we have strictly more direct deps than is necessary. We should just depend on go-libp2p for these things.
I think what needs to happen here is:
gx-go rewrite --undo && gx-go rewrite
so we can see it picking up the right deps from libp2pThis is vaguely related to #599 in that it surfaced in #643.
The text was updated successfully, but these errors were encountered: