Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure LEB-encoded integers are in canonical form #584

Closed
phritz opened this issue Jun 21, 2018 · 1 comment
Closed

ensure LEB-encoded integers are in canonical form #584

phritz opened this issue Jun 21, 2018 · 1 comment
Labels
help wanted Call for participation: More complex than good-first-issue

Comments

@phritz
Copy link
Contributor

phritz commented Jun 21, 2018

https://docs.google.com/document/d/12xNPzVCPSC2bTv7myxNRoMGx79AqFHQb89LfmRcFpGc/edit#bookmark=id.hb76ig9956ej

I think this might just be as simple as canonicalizing the bits we get from big.Int in {attofil, bytesamount, channelid, etc}. Maybe they are already canonicalized, but doesn't hurt to add a check. I doubt (?) whether it's worth checking when decoding if the representation is canonical, seems like wasted work.

@phritz phritz added the help wanted Call for participation: More complex than good-first-issue label Sep 11, 2018
@phritz
Copy link
Contributor Author

phritz commented Mar 27, 2019

given filecoin-project/specs#131, this is likely no longer relevant as we might not be leb128 encoding integers at all. if that is true, we can close this

@anorth anorth closed this as completed Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Call for participation: More complex than good-first-issue
Projects
None yet
Development

No branches or pull requests

3 participants