Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update show command to handle messages out of blocks #3196

Closed
ZenGround0 opened this issue Aug 7, 2019 · 0 comments · Fixed by #3203
Closed

Update show command to handle messages out of blocks #3196

ZenGround0 opened this issue Aug 7, 2019 · 0 comments · Fixed by #3203
Assignees

Comments

@ZenGround0
Copy link
Contributor

Description

After some initial exploration into updating the block explorer and the network stats dashboard and some helpful hints from @travisperson it looks like decoding the values output from dag get on the front end will be more onerous than it is worth. More importantly that decoding is really go-filecoin's job so the node's API should do that for us.

Acceptance criteria

Three new pieces of CLI functionality
(1) a --full flag on show block which returns the block header with messages and receipts embedded directly in it. We'll use this flag to keep the old behavior
(2) a show messages command that returns a properly decoded SignedMessage array given the Messages cid from a block header
(3) a show receipts command. Ditto (2) for receipts

These three userfacing endpoints will rely on the following internals:
(a) a new FullBlock type which may be useful elsewhere
(b) GetMessages function on the chain state plumbing/porcelain
(c) GetReceipts function on the chain state plumbing/porcelain

b & c are very close to being done because the prep work already piped a message store to the chain state.

Risks + pitfalls

Where to begin

start with the internals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant