Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistant capitalization in HTTP API #1153

Closed
victorb opened this issue Oct 12, 2018 · 3 comments
Closed

Consistant capitalization in HTTP API #1153

victorb opened this issue Oct 12, 2018 · 3 comments

Comments

@victorb
Copy link

victorb commented Oct 12, 2018

Sometimes the HTTP API returns fields with capitalized keys and sometimes not. Maybe has something to do with streaming?

Example:

Non-capitalized

$ curl localhost:3453/api/orderbook/asks
{"price":"1","size":"5000000000","owner":"fcqup6fswj2w8kkkryyf85wtfz66j99tx85uvjgan","id":22}
{"price":"5","size":"10","owner":"fcqaany0rx436dwjyuy3u8hsel87z2wmgdvelea3z","id":5}
{"price":"2.5","size":"200000","owner":"fcqdsls5fz64x0xleupt6dnq9gtveke056q0zrsua","id":9}
{"price":"1","size":"3221225472","owner":"fcq3qu2y50rwaq5h9ewl25h7jcrxxl7wmd45sa8w3","id":15}
{"price":"3","size":"5000000","owner":"fcqdft745rauztq9adatanx6q3a4mv0rvtfl6gfuk","id":8}
{"price":"2.6","size":"200001","owner":"fcqyv0v8ctwzd9vd8gu4f683y6vyvyh8ru5ffyn3s","id":19}
{"price":"1","size":"10","owner":"fcq5y65n23xdkcx2ymakflxpxqhkvewnwswp0me52","id":0}

Capitalized

$ curl localhost:3453/api/wallet/addrs/ls
{"Address":"fcqw66dxelsajhpzz3t4z3mzmpueypedlqfef34w8"}
@victorb victorb changed the title Consistency in HTTP API Consistant capitalization in HTTP API Oct 12, 2018
@phritz
Copy link
Contributor

phritz commented Oct 19, 2018

Thanks for the report. We're going to overhaul our output encoding, I'll make sure this item is on the radar for that.

@mishmosh
Copy link
Contributor

FYI @eingenito

@anorth anorth added the A-api label Jul 22, 2019
@anorth
Copy link
Member

anorth commented Jul 23, 2019

Should be resolved by #3098

@anorth anorth closed this as completed Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants