-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
state machine spec: decide & doc whether nonce is needed only for account actors #78
Comments
Probably nonces only on account actors. Should discuss. |
Question: Is it worth complicating the send logic to differentiate between account actors and others in such a way? |
I really like this idea, especially because of the direction it pushes us in. This would mean moving the nonce from the Actor object into the AccountActor state, which also means we should move the nonce from being a top level field on the Message type to being a parameter of the call. In order for it to be a call parameter, we need to have 'sending a message from the account actor' actually be a message to the account actor requesting it make a call on another actor. So a message to call 'CommitSector' on a miner actor would look like:
This would also make it make sense to put the messages signature in a place where logic on the account actor could validate it. This would be a pretty significant change, and the effect on end users would be mostly more complicated message creation logic. So I think we should probably not do this one right now... |
Needs to be discussed with dev. |
@anorth Would be good to get your thoughts on this issue as well. |
I don't forsee any major issues. I agree with the desire to do so and also not to do it right now. Since it's a real simplification I think we should strongly consider doing it before we declare the protocol testnet-ready, but we may decide to postpone it again at that point. It's more or less just a matter of coding. |
@anorth Is there a place in the go-filecoin priorities for priorities pending review? We can maybe add this one to that list and then decide where it should fall at some later point |
I'll make a note internally. I hope to work on on opening up our roadmap in
the near future.
…On Tue, 7 May 2019 at 03:16, Pooja ***@***.***> wrote:
@anorth <https://github.com/anorth> Is there a place in the go-filecoin
priorities for priorities pending review? We can maybe add this one to that
list and then decide where it should fall at some later point
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#78 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADMW6RLIBSOB7DCJUMJODDPUBRVTANCNFSM4GPRBN3A>
.
|
Sounds great!
…On Mon, May 6, 2019 at 16:07 Alex North ***@***.***> wrote:
I'll make a note internally. I hope to work on on opening up our roadmap in
the near future.
On Tue, 7 May 2019 at 03:16, Pooja ***@***.***> wrote:
> @anorth <https://github.com/anorth> Is there a place in the go-filecoin
> priorities for priorities pending review? We can maybe add this one to
that
> list and then decide where it should fall at some later point
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#78 (comment)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AADMW6RLIBSOB7DCJUMJODDPUBRVTANCNFSM4GPRBN3A
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#78 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABLH2S2P6ARTHKORU5MYIXLPUC2ZFANCNFSM4GPRBN3A>
.
|
We (@whyrusleeping & me) like it, but agree that this is too complex to add for now. |
Should we leave this open for now then, but mark it p3?
…On Sat, May 11, 2019 at 15:43 Friedel Ziegelmayer ***@***.***> wrote:
Closed #78 <#78>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#78 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABLH2S4M3637NMXX2EU5Q23PU4OV7ANCNFSM4GPRBN3A>
.
|
I don't think so, we have enough things here, and can reopen it when we are running out of things to do :D |
The text was updated successfully, but these errors were encountered: