Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add caller for actorWithdrawCmd #9258

Closed
jennijuju opened this issue Sep 2, 2022 · 5 comments
Closed

add caller for actorWithdrawCmd #9258

jennijuju opened this issue Sep 2, 2022 · 5 comments
Labels
dif/easy An existing lotus user should be able to pick this up P1 P1: Must be resolved
Milestone

Comments

@jennijuju
Copy link
Member

actorWithdrawCmd should now take a from address

lotus-miner actor withdraw <actor> <caller address>

the cmd should only proceed if the caller is the owner or beneficiary of the actor

@jennijuju jennijuju added P1 P1: Must be resolved dif/easy An existing lotus user should be able to pick this up FIP-0029 labels Sep 2, 2022
@jennijuju jennijuju moved this to Opportunistic in Network nv17 Sep 2, 2022
@jennijuju jennijuju added this to the Network v17 milestone Sep 2, 2022
@jennijuju jennijuju moved this from Opportunistic to Todo / In Scope in Network nv17 Sep 2, 2022
@dd45e640b42e6da7da96faee3996ef7c
Copy link
Contributor

this should follow other commands and use a --from flag

to add to the list:

extend sectors has the same problem of not being able to add a --from address

@geoff-vball
Copy link
Contributor

Implemented in #9296

actorWithdrawCmd now takes an optional --beneficiary flag to send the message from the beneficiary address. No need for a --from flag here because there are only two possible senders.

I will add a --actor flag to this command so we can specify which miner to send the message to.

Repository owner moved this from Todo / In Scope to Done in Network nv17 Sep 16, 2022
@dd45e640b42e6da7da96faee3996ef7c
Copy link
Contributor

just to get that right - if a beneficiary address is set and i send the message from the owner - the owner gets the funds?

@jennijuju
Copy link
Member Author

just to get that right - if a beneficiary address is set and i send the message from the owner - the owner gets the funds?

Nope. According to the fip it’s always to beneficiary.

@dd45e640b42e6da7da96faee3996ef7c
Copy link
Contributor

oh. this is a bool flag - then it makes sense

@jennijuju jennijuju mentioned this issue Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dif/easy An existing lotus user should be able to pick this up P1 P1: Must be resolved
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants