Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate the new WithdrawBalance to support caller as owner or beneficairy #9257

Closed
jennijuju opened this issue Sep 2, 2022 · 2 comments · Fixed by #9296
Closed

Integrate the new WithdrawBalance to support caller as owner or beneficairy #9257

jennijuju opened this issue Sep 2, 2022 · 2 comments · Fixed by #9296
Labels
area/api dif/easy An existing lotus user should be able to pick this up P1 P1: Must be resolved
Milestone
Network v17

Comments

@jennijuju
Copy link
Member

jennijuju commented Sep 2, 2022 •
edited
Loading

Two options I can think of

  • move ActorWithdrawBalance out of Storage Miner API to full node API.
    • take the caller's address as a param
    • make sure the caller is either the beneficiary or the owner
    • then proceed
    • we should rename the API to MinerWithdrawBalace probably
  • or we can keep ActorWithdrawBalance as it is today, and add a BeneficiaryWithdrawBalance

I prefer 1 personally but that might be considered as a breaking api change. if so we might wanna do 2. @magik6k @geoff-vball - thoughts?
@jennijuju jennijuju added P1 P1: Must be resolved area/api labels Sep 2, 2022
@jennijuju jennijuju moved this to Opportunistic in Network nv17 Sep 2, 2022
@jennijuju jennijuju added the dif/easy An existing lotus user should be able to pick this up label Sep 2, 2022
@jennijuju jennijuju added this to the Network v17 milestone Sep 2, 2022
@jennijuju
Copy link
Member Author

discussed in standup - we will go with @geoff-vball 's reco Option 2

@TippyFlitsUK
Copy link
Contributor

From an SP's perspective, I agree that option 2 would be the preferred option.

@geoff-vball geoff-vball mentioned this issue Sep 12, 2022
Merged
5 tasks
Repository owner moved this from Opportunistic to Done in Network nv17 Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/api dif/easy An existing lotus user should be able to pick this up P1 P1: Must be resolved
Projects
No open projects
Network nv17
Status: Done
Milestone
Network v17
Development

Successfully merging a pull request may close this issue.

feat: api/cli: beneficiary withdraw api and cli filecoin-project/lotus
2 participants
@TippyFlitsUK @jennijuju