Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calibration network genesis should have a faucet account for tokens and datacap #12165

Closed
2 of 9 tasks
aarshkshah1992 opened this issue Jun 27, 2024 · 6 comments
Closed
2 of 9 tasks
Assignees
Labels
kind/feature Kind: Feature

Comments

@aarshkshah1992
Copy link
Contributor

Checklist

  • This is not brainstorming ideas. If you have an idea you'd like to discuss, please open a new discussion on the lotus forum and select the category as Ideas.
  • I have a specific, actionable, and well motivated feature request to propose.

Lotus component

  • lotus daemon - chain sync
  • lotus fvm/fevm - Lotus FVM and FEVM interactions
  • lotus miner/worker - sealing
  • lotus miner - proving(WindowPoSt/WinningPoSt)
  • lotus JSON-RPC API
  • lotus message management (mpool)
  • Other

What is the motivation behind this feature request? Is your feature request related to a problem? Please describe.

Caliberation network genesis should have a faucet account for tokens and datacap.

Describe the solution you'd like

Only migrate the f090 Actor to a keyless Actor if it is a multisig.

Describe alternatives you've considered

No response

Additional context

No response

@aarshkshah1992 aarshkshah1992 added the kind/feature Kind: Feature label Jun 27, 2024
@BigLep BigLep changed the title Caliberation network genesis should have a faucet account for tokens and datacap Calibration network genesis should have a faucet account for tokens and datacap Jun 27, 2024
@BigLep
Copy link
Member

BigLep commented Jun 27, 2024

Related butterfly issue (#12160 ), which links to Slack thread with more info.

@rjan90 rjan90 added this to FilOz Jun 30, 2024
@rjan90 rjan90 moved this to 📌 Triage in FilOz Jun 30, 2024
@dd45e640b42e6da7da96faee3996ef7c
Copy link
Contributor

dd45e640b42e6da7da96faee3996ef7c commented Jul 1, 2024

isn't the FIPs implementation wrong if this gets done on a non multisig f090 in the first place?

the fip explicitly says that it only applies to a multisig f090 actor.

Convert f090 actor type from a multisig to account type

this should not need network specific implementations.

The new account actor should be keyless, like f099

this branch should never been reached if its not a multisig f090

@aarshkshah1992
Copy link
Contributor Author

@f8-ptrk

The implementation now ensures that f090 is a multisig before doing the migration. Please see filecoin-project/go-state-types#281.

@aarshkshah1992 aarshkshah1992 self-assigned this Jul 2, 2024
@rjan90
Copy link
Contributor

rjan90 commented Jul 2, 2024

We will keep the ticket open until the Calibration upgrade has happened.

@rjan90 rjan90 moved this from 📌 Triage to ⌨️In Progress in FilOz Jul 2, 2024
@dd45e640b42e6da7da96faee3996ef7c
Copy link
Contributor

dd45e640b42e6da7da96faee3996ef7c commented Jul 2, 2024

@aarshkshah1992 my worries were non public networks here that would have needed adjustment too if this would have been solved via a calib/butterfly specific fix

@rjan90
Copy link
Contributor

rjan90 commented Jul 22, 2024

Closing ticket as completed now that the calibration upgrade has happened.

@rjan90 rjan90 closed this as completed Jul 22, 2024
@rjan90 rjan90 moved this from ⌨️In Progress to 🎉 Done in FilOz Jul 22, 2024
@rjan90 rjan90 moved this from 🎉 Done to ☑️Done (Archive) in FilOz Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Kind: Feature
Projects
Status: ☑️ Done (Archive)
Development

No branches or pull requests

4 participants