-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thinking on the R_version check #24
Comments
Another great idea @zhengle-advantaseeds! I think we could easily support this. I've just got to brush up on string and numeric conversions in Delphi Pascal to make sure the registry query can support this. We could implement it in the "inst/installation/code.iss" file. |
Great! Thanks for the very nice package! |
I also vote for that. |
@trybik and @zhengle-advantaseeds. Can you explain some of your thoughts around supporting this? See my response to #34. The challenge with registry queries, is we would have to build all possible registry entries and query them specifically. That build process in Delphi Pascal would be dictated by the string entered in |
Here I have no idea what would check for current OS's R version involve, implementation-wise. I will again refer to idea that's given in the R DESCRIPTION file specification:
I think this is quite important because ATM if I wrote an app with most current R version, which was "3.4.1" and the user did not update his R (more frequent case), or has a newer R ver. "3.4.3", then either his OS's R becomes the newer one and he is forced to update all packages (quite annoying), or he just ends up with additional older R installation (much less annoying). |
I agreed with @trybik. However, I did look into the Pascal script in the Inno, and it returns strings. Like @Dripdrop12 said, it would be a good amount of workload to implement 'R(>=3.0.0)'. Instead, could we modified the config file? For example, Step 1: in the RInno, use R_version as the minimum required version: for example, 0.0.5 I am more familiar with R, so I can help with any workloads related to the R. |
Done :) |
Currently, the .iss script is checking for an exact match of the R_version specified. Would it possible to check the R_version for a set? For example, instead of specifying R_version = '3.4.1', we can specify R_version >= '3.0.0'.
The text was updated successfully, but these errors were encountered: