Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript definitions #20

Closed
ukstv opened this issue Mar 27, 2018 · 6 comments
Closed

TypeScript definitions #20

ukstv opened this issue Mar 27, 2018 · 6 comments

Comments

@ukstv
Copy link
Collaborator

ukstv commented Mar 27, 2018

Hey @feross, are you open to including TypeScript type definitions in the project?

@feross
Copy link
Owner

feross commented Apr 15, 2018

Sure. My only reservation is who will maintain the types in the future? I don't use TypeScript myself.

@ukstv
Copy link
Collaborator Author

ukstv commented Apr 16, 2018

Guess, the community would, that is no one or you :( Anyway, it’s easier to maintain the definitions if they are distributed with the library rather than packaged separately.

@feross
Copy link
Owner

feross commented Apr 17, 2018

Without someone volunteering to maintain them, I'd rather have no definitions than out-of-date ones.

@feross feross closed this as completed Apr 17, 2018
@ukstv
Copy link
Collaborator Author

ukstv commented Apr 21, 2018

Ok, I am the volunteer, since my stuff depends on safe-buffer.

@ukstv
Copy link
Collaborator Author

ukstv commented Apr 21, 2018

Worth reconsidering?

@feross
Copy link
Owner

feross commented Apr 21, 2018

Sure, want to send a pull request with the types file and I'll take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants